Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call super method /w given arg when extending onOpen & onClose #101

Merged
merged 1 commit into from Nov 8, 2019

Conversation

zenflow
Copy link
Member

@zenflow zenflow commented Nov 8, 2019

@zenflow zenflow requested a review from limonte November 8, 2019 18:16
@github-actions
Copy link

github-actions bot commented Nov 8, 2019

Pull Request Test Coverage Report for Build 6bc10bcd4fc566e0e23970062a77c2fe084eb225-PR-101

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.652%

Totals Coverage Status
Change from base Build 5c04177950fb45d3af7122a7bbc0dc29c1370a8d: 0.0%
Covered Lines: 33
Relevant Lines: 34

💛 - Coveralls

@limonte limonte merged commit 4362bdc into master Nov 8, 2019
@limonte limonte deleted the fix-extending-onOpen-and-onClose branch November 8, 2019 18:22
limonte pushed a commit that referenced this pull request Nov 8, 2019
## [2.0.2](v2.0.1...v2.0.2) (2019-11-08)

### Bug Fixes

* call super method /w given arg when extending onOpen & onClose ([#101](#101)) ([4362bdc](4362bdc))
@limonte
Copy link
Member

limonte commented Nov 8, 2019

🎉 This PR is included in version 2.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

limonte pushed a commit that referenced this pull request Nov 6, 2022
## [2.0.2](v2.0.1...v2.0.2) (2019-11-08)

### Bug Fixes

* call super method /w given arg when extending onOpen & onClose ([#101](#101)) ([15a099e](15a099e))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeScript definitions are incorrect.
2 participants