Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(params): add heightAuto boolean parameter (default true) #1112

Merged
merged 1 commit into from May 27, 2018

Conversation

Projects
None yet
1 participant
@limonte
Copy link
Member

commented May 27, 2018

Closes #1111

SweetAlert2 currently adds height: auto !important to html and body. The reason of that could be found in #781 and #1107

This behavior might be too intrusive and break some layouts. This PR will allow users to disable applying height: auto !important by setting heightAuto to false.

@limonte limonte merged commit 5afbbd8 into master May 27, 2018

6 checks passed

WIP ready for review
Details
bundlesize dist/sweetalert2.all.min.js: 14.17KB < maxSize 15KB (gzip)(48B larger than master, careful!)
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@limonte limonte deleted the feature/optional-height-auto branch May 28, 2018

brynmrk added a commit to brynmrk/sweetalert2 that referenced this pull request Oct 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.