Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(input): add .checkValidity() support #1284

Merged
merged 1 commit into from Nov 8, 2018

Conversation

Projects
None yet
1 participant
@limonte
Copy link
Member

commented Nov 8, 2018

Allow this use-case:

Swal({
  input: 'tel',
  inputAttributes: {
    pattern: '[0-9]{3}-[0-9]{3}-[0-9]{4}'
  },
  validationMessage: 'Invalid phone number'
})

@limonte limonte merged commit 361d2bd into master Nov 8, 2018

6 checks passed

WIP Ready for review
Details
bundlesize dist/sweetalert2.all.min.js: 14.93KB < maxSize 15KB (gzip)(24B larger than master, careful!)
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

limonte pushed a commit that referenced this pull request Nov 8, 2018

chore(release): 7.29.0 [skip ci]
# [7.29.0](v7.28.13...v7.29.0) (2018-11-08)

### Features

* **input:** add .checkValidity() support ([#1284](#1284)) ([361d2bd](361d2bd))
@limonte

This comment has been minimized.

Copy link
Member Author

commented Nov 8, 2018

🎉 This PR is included in version 7.29.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@limonte limonte added the released label Nov 8, 2018

limonte pushed a commit that referenced this pull request Nov 8, 2018

chore(release): 7.29.0 [skip ci]
# [7.29.0](v7.28.13...v7.29.0) (2018-11-08)

### Features

* **input:** add .checkValidity() support ([#1284](#1284)) ([361d2bd](361d2bd))

@limonte limonte deleted the feat/check-calidity branch Nov 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.