Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix crash if swal2 action buttons classes are applied to elements in html prop #1420
Feb 20, 2019
5 checks passed
Hi @limonte your test passes even with the bug present. Infact the issue reported stops the swal execution after the swal is built but before is shown. At the time the error appear both the button defined in
Is my understanding correct?
If you execute that method on the example provided for this issue, it returns
What do you think @limonte? Should we adjust that as well? Or is it considered a breaking change?