Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update internal params in Swal.update() #1505

Merged
merged 1 commit into from Mar 30, 2019

Conversation

Projects
None yet
2 participants
@limonte
Copy link
Member

commented Mar 30, 2019

Fixes #1386

@coveralls

This comment has been minimized.

Copy link

commented Mar 30, 2019

Pull Request Test Coverage Report for Build 4778

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.005%) to 91.128%

Files with Coverage Reduction New Missed Lines %
dist/sweetalert2.js 2 91.13%
Totals Coverage Status
Change from base Build 4775: 0.005%
Covered Lines: 1197
Relevant Lines: 1263

💛 - Coveralls

@limonte limonte merged commit e81d840 into master Mar 30, 2019

6 checks passed

WIP Ready for review
Details
bundlesize dist/sweetalert2.all.min.js: 15.04KB < maxSize 16KB (gzip)(17B larger than master, careful!)
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@limonte limonte deleted the fix/update-internal-params branch Mar 30, 2019

limonte pushed a commit that referenced this pull request Mar 30, 2019

chore(release): 8.7.1 [skip ci]
## [8.7.1](v8.7.0...v8.7.1) (2019-03-30)

### Bug Fixes

* update internal params in Swal.update() ([#1505](#1505)) ([e81d840](e81d840))
@limonte

This comment has been minimized.

Copy link
Member Author

commented Mar 30, 2019

🎉 This PR is included in version 8.7.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@limonte limonte added the released label Mar 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.