New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Known Login issue #25

Closed
zoglesby opened this Issue Apr 11, 2018 · 10 comments

Comments

3 participants
@zoglesby

zoglesby commented Apr 11, 2018

When trying to login with my known site I authenticate, grant permission and it returns back to the app login page. I get the validating code message and then an "Authorization failed" message.

I have checked that the auth tokens are being created on the server side. Let me know what I can do to provide you with more information to work on this.

The domain that I am using in https://zach.oglesby.co and it works with alltogethernow.io and Indigenous iOS.

@swentel

This comment has been minimized.

Owner

swentel commented Apr 11, 2018

So, Ironically, the "Authentication failed" is used twice in my code so I don't have a clear pointer for myself. I'm going to add more debugging information to the code and roll out a new version as soon as possible, that will make bug reports easier :)

I'll check the https://withknown.com/ project too to figure out if the authentication works different or not (although it shouldn't as far as I know)

@pstuifzand

This comment has been minimized.

pstuifzand commented Apr 11, 2018

There is not response_type=code used, I guess.

(Originally published at: https://publog.stuifzandapp.com/posts/529)

@swentel

This comment has been minimized.

Owner

swentel commented Apr 11, 2018

hmm you're right, that's not set, hopefully it's as simple as that.
Interesting that indieauth.com doesn't complain about that.

swentel added a commit that referenced this issue Apr 11, 2018

@swentel

This comment has been minimized.

Owner

swentel commented Apr 11, 2018

@zoglesby I pushed a new release, should be available soon.

I added more debug messages to get a clearer view on what might go wrong.
But let's just simply hope that adding the response_type fixed it already, that would be awesome.

@swentel swentel added the IndieAuth label Apr 11, 2018

@zoglesby

This comment has been minimized.

zoglesby commented Apr 11, 2018

The new error is “Value acess_token of Java.lang.String cannot be converted to json_object”

@swentel

This comment has been minimized.

Owner

swentel commented Apr 11, 2018

Aha, that sounds like the response from the token endpoint is not returning json but probably just plain text. Good pointer! Will digg a bit through the code of Known (or other clients).

@swentel

This comment has been minimized.

Owner

swentel commented Apr 11, 2018

So it seems the iOS client had trouble with that too and added legacy code. Eddie opened an issue which is now closed but did not fix the issue properly afaics.

Will check to add legacy code too.

swentel added a commit that referenced this issue Apr 11, 2018

@swentel

This comment has been minimized.

Owner

swentel commented Apr 11, 2018

@zoglesby So another release, will come up in a few minutes.
Crossing fingers that it will work now, added code that should be able to get the access token from the body in an url encoded string.

@zoglesby

This comment has been minimized.

zoglesby commented Apr 11, 2018

That fixed the issue.

@swentel

This comment has been minimized.

Owner

swentel commented Apr 11, 2018

Awesome!

@swentel swentel closed this Apr 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment