Skip to content

Conversation

@swhitty
Copy link
Owner

@swhitty swhitty commented Oct 11, 2024

Fixes issue #49 when IDs include percent encoded characters when used as URL fragments.

Removes percent encoding when resolving the ID on platforms where available.

@codecov
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 84.13%. Comparing base (67ed5e4) to head (9de08c3).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
SwiftDraw/URL+Fragment.swift 55.55% 4 Missing ⚠️
SwiftDraw/LayerTree.Builder.swift 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #50      +/-   ##
==========================================
- Coverage   84.18%   84.13%   -0.05%     
==========================================
  Files          77       78       +1     
  Lines        5526     5535       +9     
==========================================
+ Hits         4652     4657       +5     
- Misses        874      878       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swhitty swhitty force-pushed the fix-urlencoded-fragment branch from cfa64e1 to 9de08c3 Compare October 11, 2024 22:46
@swhitty swhitty merged commit 196126c into main Oct 11, 2024
13 of 15 checks passed
@swhitty swhitty deleted the fix-urlencoded-fragment branch October 11, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants