Add functions for individual covariance functions. #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akleeman
force-pushed
the
breakout_covariance_functions
branch
from
c47e49c to
4415ac0
Compare
benjamin0
reviewed
Jul 3, 2018
Contributor
benjamin0
left a comment
benjamin0
left a comment
There was a problem hiding this comment.
One comment, but lgtm!
| // The acos operator doesn't behave well near |1|. acos(1.), for example, | ||
| // returns NaN, so here we do some special casing, | ||
| double dot_product = x.dot(y) / (x.norm() * y.norm()); | ||
| if (dot_product > 1. - 1e-16) { |
Contributor
There was a problem hiding this comment.
Can we name 1e-16 as "epsilon" somewhere so we can reuse it?
akleeman
force-pushed
the
breakout_covariance_functions
branch
from
a7d799f to
a829f64
Compare
This was referenced Dec 13, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to build combinations of spatial metrics.