Exclude Fixed Parameters #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
seth-swiftnav
left a comment
seth-swiftnav
left a comment
There was a problem hiding this comment.
get_params_as_vector might be better named as get_tunable_params_as_vector. Since the function is designed to be used with the get_upper/lower_bounds functions, perhaps a single function which returns a struct of three equal-length vectors might be cleaner.
vectors of doubles which should both keep the params and lower/upper bounds consistent and make the intended use of those functions more obvious.
seth-swiftnav
approved these changes
Aug 11, 2018
This was referenced Dec 13, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure to exclude lower bounds when tuning using fixed parameters.