Add Valgrind Targets to Unit Tests [DEVINFRA-550] #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jungleraptor
requested review from
RReichert,
jbangelo,
silverjam and
woodfell
silverjam
approved these changes
Sep 29, 2021
Contributor
silverjam
left a comment
silverjam
left a comment
There was a problem hiding this comment.
LGTM-- please clean up PR title before merge (remove username and add Jira tag)
jbangelo
approved these changes
Sep 29, 2021
Contributor
jbangelo
left a comment
jbangelo
left a comment
There was a problem hiding this comment.
Looks great! Exactly what I was hoping for. Thanks for the quick turn around on this @isaactorz !
jungleraptor
changed the title
woodfell
approved these changes
Sep 29, 2021
RReichert
approved these changes
Sep 30, 2021
jungleraptor
force-pushed
the
itorres/add-valgrind-to-swift-test
branch
from
d9da73a to
a9bdecb
Compare
Often in Starling when a unit test is added with swift_add_test, a corresponding valgrind-membeck target is added. For convenience, an optional parameter, VALGRIND_MEMCHECK, has been added to swift_add_test to automatically create a valgrind target from the unit test definition.
jungleraptor
force-pushed
the
itorres/add-valgrind-to-swift-test
branch
from
a9bdecb to
31d066a
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
This was referenced Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
Added a
VALGRIND_MEMCHECKoption toswift_add_testfor unit tests. This will callswift_valgrind_memcheckwith a default set of parameters. Respects the${PROJECT_NAME}_ENABLE_PROFILINGoption.