Skip to content

Add FindSwiftlets.cmake #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 6, 2020
Merged

Add FindSwiftlets.cmake #53

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca901a3
Add FindSwiftlets.cmake
IsakTjernberg Apr 24, 2020
62534de
Fix review comment
IsakTjernberg May 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions FindSwiftlets.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
include("GenericFindDependency")
option(swiftlets_ENABLE_TESTS "" OFF)
GenericFindDependency(
TARGET swiftlets
SOURCE_DIR swiftlets
Copy link
Contributor

@woodfell woodfell May 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't strictly speaking required - GenericFindDependency searches a load of paths based on the target name to look for the submodule. It won't hurt to leave it there, it's just not required.

Copy link
Contributor Author

@IsakTjernberg IsakTjernberg May 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left this here as it seems to be used by quite many other modules also.

Copy link
Contributor

@woodfell woodfell May 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's really only needed when the source code is in a directory with a different name from the target name, or when the source code is in a subdirectory in the submodule (like gnss-converters or libsbp). In this case the names as the same though

SYSTEM_INCLUDES
)