Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deserializing empty payloads on MSG_SETTINGS_READ_BY_INDEX doesn't work #106

Closed
mfine opened this issue Apr 14, 2015 · 2 comments
Closed

Comments

@mfine
Copy link
Contributor

mfine commented Apr 14, 2015

>>> import sbp
>>> s = sbp.SBP(msg_type=0xA2, sender=1781, length=0, payload="", crc=0xCCE3)
>>> import sbp.table
>>> sbp.table.dispatch(s)
sbp/table.py:76: RuntimeWarning: SBP payload deserialization error! 0xa2
  RuntimeWarning)
<SBP (preamble=0x55, msg_type=0xA2, sender=1781, length=0, payload=, crc=0xCCE3)>
>>>

Not sure where or if the serialization is failing here, but came across this failure from a live log.

@mfine
Copy link
Contributor Author

mfine commented Apr 14, 2015

Hmm, this is just a bad message - needs a payload, according to our specs.

@mfine mfine closed this as completed Apr 14, 2015
@fnoble
Copy link
Contributor

fnoble commented Apr 14, 2015

There are some messages in the spec that can have two different payloads in different contexts. I made some notes on the doc about how to eliminate some of these, I think we should try to do that ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants