Skip to content

Conversation

@silverjam
Copy link
Contributor

No description provided.

@silverjam silverjam requested a review from notoriaga September 22, 2021 20:47
@silverjam
Copy link
Contributor Author

@notoriaga let me know if this conflicts with your work and I'll close

Copy link
Contributor

@notoriaga notoriaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope should be good, thanks!

@notoriaga
Copy link
Contributor

I got the same 0.0/-0.0 on my pr, not sure what's up with that. Maybe tests in a binary crate don't use the lock file and something in serde_json changed

@silverjam
Copy link
Contributor Author

I got the same 0.0/-0.0 on my pr, not sure what's up with that. Maybe tests in a binary crate don't use the lock file and something in serde_json changed

I mentioned the issue here serde-rs/json#801 -- but it looks like this might be "correct" behavior since everything in JSON is a float?

@silverjam
Copy link
Contributor Author

silverjam commented Sep 22, 2021

To different solutions:

  • df0da9a (just pin serde)
  • d380158 (this is probably the better long term solution)

@silverjam silverjam merged commit a14a851 into master Sep 22, 2021
@silverjam silverjam deleted the silverjam/update-swiftnav branch September 22, 2021 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants