SBP doc: Table 2.0.1. s/Payload/Packet/ #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test PASSed. |
|
Perhaps "Message" instead of "Packet" for consistency? We don't tend to refer to packets much. |
|
Test PASSed. |
mookerji
added a commit
that referenced
this pull request
May 3, 2015
SBP doc: Table 2.0.1. s/Payload/Packet/
RReichert
pushed a commit
that referenced
this pull request
Jul 30, 2022
) cmake - Rollback SonarCloud Changes * Revert "sonarcloud: Use Inclusions Property (#121)" This reverts commit 1773f34dbdbb5c551a0eab8d7f95b66e81eeb550. * Revert "Fix Sonarcloud sonar-project.properties (#120)" This reverts commit 3550197d7033f9eccfdc3611e335e91227ce92df. Rolling back recent sonarcloud changes until we get a better grip on how to properly configure C/C++ projects. Triggered-By: cmake ea15fa9b1e5dd296d932866ee0b9a1d2eab9296c Upstream-PR: http://github.com/swift-nav/cmake/pull/126
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chapter 2 "Message Structure", Table 2.0.1: Swift Binary Protocol message structure
The bottom row says "Total Payload Length" but it should read "Total Packet Length" because this table is describing a whole packet including the header and footer.
All the other tables in the doc describe payloads, so they correctly say "Total Payload Length"