Skip to content

Conversation

@ljbade
Copy link
Contributor

@ljbade ljbade commented Dec 20, 2022

Description

Implements the request in #1240 for a name attribute in the C++ MessageTrait class.

It results in something like:

template <>
struct MessageTraits<sbp_msg_acknowledge_t> {
  static constexpr sbp_msg_type_t id = SbpMsgAcknowledge;
  static constexpr char *name = "MSG_ACKNOWLEDGE";
...

For each message

@swift-nav/devinfra

API compatibility

Does this change introduce a API compatibility risk?

No it is adding a new class member only.

JIRA Reference

https://swift-nav.atlassian.net/browse/DEVINFRA-1034

@ljbade ljbade requested review from a team and silverjam as code owners December 20, 2022 05:52
@silverjam
Copy link
Contributor

@isaactorz any hints on what's going on with the bazel build? Not an error I've seen before.

@ljbade
Copy link
Contributor Author

ljbade commented Dec 20, 2022

@isaactorz any hints on what's going on with the bazel build? Not an error I've seen before.

It's failing on master too, looking at the latest auto submodule update commit.

@ljbade ljbade merged commit 673291c into master Dec 20, 2022
@ljbade ljbade deleted the ljbade/di-1034 branch December 20, 2022 06:37
@jungleraptor
Copy link
Contributor

@silverjam @ljbade Might have something to do with 6.0 LTS being released yesterday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants