Skip to content

Conversation

@Davinco
Copy link
Contributor

@Davinco Davinco commented Jan 9, 2023

Description

A new version of the SSR Satellite APC message and SSR Tile Definition message is added which extends the current messages with a timestamp, update interval, solution id and iod fields. See details here:

API compatibility

No, this PR adds new messages and the current messages are still functional but labelled as deprecated.

JIRA Reference

https://swift-nav.atlassian.net/browse/PC-116

@Davinco Davinco requested review from a team, notoriaga and silverjam as code owners January 9, 2023 22:39
@Davinco
Copy link
Contributor Author

Davinco commented Jan 9, 2023

Putting up this PR to get some feedback. I got the same test failure when I ran this locally, is there something wrong with how the spec/tests/yaml/swiftnav/sbp/ssr/test_MsgSsrSatelliteApc.yaml was generated? or with my input file? I created the json file in sat_apc.zip and ran the command from the howto PYTHONPATH="python/" python generator/json2test.py --input sat_apc.json --output spec/tests/yaml/swiftnav/sbp/ssr/test_MsgSsrSatelliteApc.yaml, and then ran make gen.

Adds n_apc field so that the apc list is properly encoded.
@silverjam
Copy link
Contributor

@Davinco I think the json2test script is probably not catching that the apc array is a variable size array, so the "c_decoded_fields" needs to be set to indicate how many elements are in the apc array.

@Davinco
Copy link
Contributor Author

Davinco commented Jan 11, 2023

@Davinco I think the json2test script is probably not catching that the apc array is a variable size array, so the "c_decoded_fields" needs to be set to indicate how many elements are in the apc array.

Ah right, thanks for the help @silverjam

@Davinco Davinco changed the title Add new SSR Satellite APC message [PC-116] Add new SSR Satellite APC and Tile Definition message [PC-116] Jan 11, 2023
@Davinco Davinco requested a review from silverjam January 11, 2023 23:38
@Davinco Davinco merged commit 0e12e99 into master Jan 17, 2023
@Davinco Davinco deleted the david/pc-116 branch January 17, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants