Skip to content

Device iterator #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 19, 2015
Merged

Device iterator #150

merged 4 commits into from
May 19, 2015

Conversation

@denniszollo
Copy link
Contributor

@denniszollo denniszollo commented May 19, 2015

@mfine This is pretty general to me and does the job.

@swiftnav-jenkins
Copy link
Contributor

swiftnav-jenkins commented May 19, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
http://zazu.ci.swiftnav.com/job/libsbp_Pull_Requests/105/
Test FAILed.

@swiftnav-jenkins
Copy link
Contributor

swiftnav-jenkins commented May 19, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://zazu.ci.swiftnav.com/job/libsbp_Pull_Requests/106/
Test PASSed.

mfine
mfine reviewed May 19, 2015
View reviewed changes
python/sbp/client/loggers/device_iterator.py Outdated
Copy link
Contributor

@mfine mfine May 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about just self.queue? The my is redundant.

@mfine
Copy link
Contributor

mfine commented May 19, 2015

This looks great!

@denniszollo
Copy link
Contributor Author

denniszollo commented May 19, 2015

Responded to PR feedback but rebased.

@swiftnav-jenkins
Copy link
Contributor

swiftnav-jenkins commented May 19, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://zazu.ci.swiftnav.com/job/libsbp_Pull_Requests/107/
Test PASSed.

@mfine
Copy link
Contributor

mfine commented May 19, 2015

looks great, ship it.

@swiftnav-jenkins
Copy link
Contributor

swiftnav-jenkins commented May 19, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://zazu.ci.swiftnav.com/job/libsbp_Pull_Requests/108/
Test PASSed.

@denniszollo
Create a device_logger iterator interface which
7a48d44 
Uses a Queue to communicate between callback and iterator
@swiftnav-jenkins
Copy link
Contributor

swiftnav-jenkins commented May 19, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://zazu.ci.swiftnav.com/job/libsbp_Pull_Requests/109/
Test PASSed.

@swiftnav-jenkins
Copy link
Contributor

swiftnav-jenkins commented May 19, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://zazu.ci.swiftnav.com/job/libsbp_Pull_Requests/110/
Test PASSed.

denniszollo added a commit that referenced this pull request May 19, 2015
@denniszollo
Merge pull request #150 from denniszollo/device_iterator
71b7e95 
Device iterator
@denniszollo denniszollo merged commit 71b7e95 into swift-nav:master May 19, 2015
silverjam pushed a commit that referenced this pull request Mar 27, 2023
@swiftnav-svc-jenkins
Auto submodule update: cmake - Turn SonarCloud duplicate detection of…
0216141 
…f for unit tests (#150) (#1310)

cmake - Turn SonarCloud duplicate detection off for unit tests
Triggered-By:	cmake	d7a20ec514ef83525d734d8ee39e03c712adbedc
Upstream-PR:	http://github.com/swift-nav/cmake/pull/150
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@denniszollo @swiftnav-jenkins @mfine