Skip to content

Conversation

@martin-swift
Copy link
Contributor

@silverjam Can you do the honors again for the autogen?

@martin-swift
Copy link
Contributor Author

bumpity bump bump... @ljbade can you confirm that this is what you initially intended? @silverjam - if you don't have the bandwidth to auto-gen I can take a shot at dockerizing it; lemme know...

@silverjam
Copy link
Contributor

@martin-swift updated

uint32 update_interval = 5;
uint32 iod_ssr = 6;
uint32 update_interval = 4;
uint32 iod_ssr = 5;
Copy link
Contributor Author

@martin-swift martin-swift Jul 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yow:

Non-required fields can be removed, as long as the field number is not used
again in your updated message type. You may want to rename the field 
instead, perhaps adding the prefix "OBSOLETE_", or make the field number
reserved, so that future users of your .proto can't accidentally reuse the number.

So if we rev a message that people are already using we can't delete a field unless we don't care about backwards compatibility?

@martin-swift
Copy link
Contributor Author

thanks @silverjam ; anyone know what's up with the travis failures?

@silverjam
Copy link
Contributor

silverjam commented Jul 14, 2019 via email

@silverjam
Copy link
Contributor

silverjam commented Jul 14, 2019 via email

@martin-swift martin-swift merged commit 2da64e3 into master Jul 15, 2019
@martin-swift martin-swift deleted the martin/stec-cleanup branch July 15, 2019 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants