Skip to content

Use common test targets module #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 23, 2019
Merged

Use common test targets module #740

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3968e4a
Use common test targets module
Oct 18, 2019
22f430e
Code review comments
Oct 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions c/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ swift_create_project_options(
TEST_PACKAGES "Check"
)
include(CodeCoverage)
include(TestTargets)
add_code_coverage_all_targets()

##########################################################
Expand Down
2 changes: 1 addition & 1 deletion c/cmake/common
Open in desktop
Submodule common updated 21 files
+38 −10 ClangFormat.cmake
+32 −12 ClangTidy.cmake
+4 −1 CodeCoverage.cmake
+9 −0 FindBenchmark.cmake
+1 −0 FindGnss-converters.cmake
+1 −0 FindJson.cmake
+10 −0 FindNlopt.cmake
+1 −0 FindOptional.cmake
+6 −0 FindPal++.cmake
+7 −0 FindPal.cmake
+1 −0 FindProtobuf.cmake
+1 −0 FindRtcm.cmake
+2 −0 FindSbp.cmake
+1 −0 FindSettings.cmake
+3 −0 FindStarling.cmake
+1 −0 FindSwiftnav.cmake
+2 −1 FindYaml-Cpp.cmake
+42 −1 GenericFindDependency.cmake
+52 −0 LanguageStandards.cmake
+12 −1 SwiftCmakeOptions.cmake
+254 −0 TestTargets.cmake
53 changes: 26 additions & 27 deletions c/test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,39 +1,38 @@
set(TEST_LIBS ${TEST_LIBS} ${CHECK_LIBRARIES} pthread sbp m)
find_package(Threads)
set(TEST_LIBS ${TEST_LIBS} ${CHECK_LIBRARIES} Threads::Threads sbp m)

# Check needs to be linked against Librt on Linux
if (${CMAKE_SYSTEM_NAME} STREQUAL "Linux")
set(TEST_LIBS ${TEST_LIBS} rt)
endif(${CMAKE_SYSTEM_NAME} STREQUAL "Linux")

FILE(GLOB generated_c_sources auto*.c)
add_executable(test_libsbp check_main.c check_edc.c check_sbp.c ${generated_c_sources})

target_link_libraries(test_libsbp PRIVATE ${TEST_LIBS})
set_target_properties(test_libsbp PROPERTIES
C_STANDARD 99
C_STANDARD_REQUIRED ON)
set(TEST_INCLUDES ${PROJECT_SOURCE_DIR}/include/libsbp)

if(MSVC)
target_include_directories(test_libsbp PRIVATE ${PROJECT_SOURCE_DIR}/include/libsbp/)
else()
target_include_directories(test_libsbp PRIVATE ${PROJECT_SOURCE_DIR}/include/libsbp/)
if(APPLE)
# Some libraries are available in non-standard places on apple.
target_include_directories(test_libsbp PRIVATE /usr/local/include)
if(APPLE)
# Some libraries are available in non-standard places on apple.
list(APPEND TEST_INCLUDES /usr/local/include)

# This is not a great way of doing this, but the proper cmake function
# target_link_directories() was introduced in version 3.13 and we need to support
# older versions for the moment. We can use target_link_libraries to pass arbitrary
# linker flags, making sure that this instance is well protected and only applies
# to a single platform. Don't use the extant link_directories() function since
# that leaks the path to other targets.
target_link_libraries(test_libsbp PRIVATE "-L/usr/local/lib")
endif()
# This is not a great way of doing this, but the proper cmake function
# target_link_directories() was introduced in version 3.13 and we need to support
# older versions for the moment. We can use target_link_libraries to pass arbitrary
# linker flags, making sure that this instance is well protected and only applies
# to a single platform. Don't use the extant link_directories() function since
# that leaks the path to other targets.
list(APPEND TEST_INCLUDES "-L/usr/local/lib")
endif()
target_code_coverage(test_libsbp AUTO ALL)

add_custom_command(
TARGET test_libsbp POST_BUILD
COMMENT "Running unit tests"
COMMAND test_libsbp
)
swift_add_test(test-libsbp
POST_BUILD
SRCS
check_main.c
check_edc.c
check_sbp.c
${generated_c_sources}
INCLUDE
${TEST_INCLUDES}
LINK
${TEST_LIBS}
)