Dzollo/pyserial timeout remove #821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timeout was causing console to disconnect during Piksi Multi restart.
Timeout made serial driver not equivalent in behavior to file driver or network driver
extends behavior from commit 9b15928 that addressed ESD-1111
Contributor
|
@denniszollo merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is to address bug report below:
After painful investigation, the bug was traced down to this change in the framer behavior when encountering a zero length byte array from the driver and on Windows only. 2d2d1f4#diff-f7e7ceb9c48458bb44be66283049a27bL106
Basically, since there was a 1 second timeout on the pyserial driver if it didn't get data in one second it could cause the framer to start iterating nothing to the handler which caused the handler to yield none.
As a side note, I sort of think we might need to throw an exception here: https://github.com/swift-nav/libsbp/blob/master/python/sbp/client/handler.py#L72 , so that at least the handler communicates that it is no longer iterating correctly. But I'm not sure what to do there so I left as is.