-
Notifications
You must be signed in to change notification settings - Fork 0
Initial swift_cc* wrappers #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| # Name for a unit test | ||
| UNIT = "unit" | ||
|
|
||
| # Name for a integration test | ||
| INTEGRATION = "integration" | ||
|
|
||
| def swift_cc_library(**kwargs): | ||
| """Wraps cc_library to enforce standards for a production library. | ||
| """ | ||
| native.cc_library(**kwargs) | ||
|
|
||
| def swift_cc_tool_library(**kwargs): | ||
| """Wraps cc_library to enforce standards for a non-production library. | ||
| """ | ||
| native.cc_library(**kwargs) | ||
|
|
||
| def swift_cc_binary(**kwargs): | ||
| """Wraps cc_binary to enforce standards for a production library. | ||
| """ | ||
| native.cc_binary(**kwargs) | ||
|
|
||
| def swift_cc_tool(**kwargs): | ||
| """Wraps cc_binary to enforce standards for a non-production library. | ||
| """ | ||
| native.cc_binary(**kwargs) | ||
|
|
||
| def swift_cc_test_library(**kwargs): | ||
| """Wraps cc_library to enforce Swift test library conventions. | ||
| """ | ||
| native.cc_library(**kwargs) | ||
|
|
||
| def swift_cc_test(name, type, **kwargs): | ||
| """Wraps cc_test to enforce Swift testing conventions. | ||
|
|
||
| Args: | ||
| name: A unique name for this rule. | ||
| type: Specifies whether the test is a unit or integration test. | ||
|
|
||
| These are passed to cc_test as tags which enables running | ||
| these test types seperately: `bazel test --test_tag_filters=unit //...` | ||
| """ | ||
|
|
||
| if not (type == UNIT or type == INTEGRATION): | ||
| fail("The 'type' attribute must be either UNIT or INTEGRATION") | ||
|
|
||
| kwargs["name"] = name | ||
| kwargs["tags"] = [type] | ||
| native.cc_test(**kwargs) | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bazel has a built in convention for splitting up tests that's similiar to how we distinguish unit vs integration tests.
The convention is
smallvslargetests: https://bazel.build/reference/test-encyclopedia#tag-conventions.The you filter with
bazel test --test_size_filters=small.Putting this behind a constant means we can change this to the conventional way if we want without a big refactor.