add testing infrastructure for sysroot builds #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@peddie First will probably help to actually upload the sysroot on PR's. |
peddie
approved these changes
Sep 28, 2023
Contributor
peddie
left a comment
peddie
left a comment
There was a problem hiding this comment.
I don't fully understand the details of this, but I fully approve the intent.
Contributor
Author
Was not very helpful for testing purposes that the only way to get a copy of the sysroot was to push a tag - so I've made it so that the resulting artifact is uploaded on every PR. You can find it here: https://github.com/swift-nav/swift-toolchains/actions/runs/6334833738?pr=22 (under |
jungleraptor
changed the title
jungleraptor
added a commit
to swift-nav/rules_swiftnav
that referenced
this pull request
Sep 29, 2023
Adds a handy `local_archive` utility. See: https://www.stevenengelhardt.com/2023/03/01/practical-bazel-local_archive-workspace-rule/ Related: swift-nav/swift-toolchains#22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an upload action so that the resulting sysroot is uploaded for testing.