Skip to content
This repository has been archived by the owner on Aug 5, 2022. It is now read-only.

heroku/nio deploy #4

Merged
merged 10 commits into from
Oct 29, 2020
Merged

heroku/nio deploy #4

merged 10 commits into from
Oct 29, 2020

Conversation

loganwright
Copy link
Member

No description provided.

heroku.md Outdated Show resolved Hide resolved
heroku.md Outdated Show resolved Hide resolved
heroku.md Outdated Show resolved Hide resolved
Copy link
Member

@tanner0101 tanner0101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. I agree with Tom's comments, then this LGTM.

.gitignore Outdated Show resolved Hide resolved
heroku.md Show resolved Hide resolved
Copy link
Contributor

@tomerd tomerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, some small edit suggestion

@tomerd
Copy link
Contributor

tomerd commented Aug 19, 2020

hi @loganwright would you like to take this over the finish line?

@MaxDesiatov
Copy link
Member

This PR still targets the master branch, while it should be main.

@tomerd tomerd self-requested a review October 14, 2020 16:41
@weissi weissi changed the base branch from master to main October 14, 2020 16:41
@weissi
Copy link
Contributor

weissi commented Oct 14, 2020

Thank you @MaxDesiatov , fixed

@loganwright
Copy link
Member Author

all comments done, ready to merge 👍

@tomerd tomerd merged commit 5d82477 into main Oct 29, 2020
@tomerd tomerd deleted the deployment-heroku branch October 29, 2020 02:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants