update process per SSWG 9/16 meeting #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motivation: the SSWG reviewed the incubation process on 9/16 and suggested changes
changes:
Sandbox
-------
* Single developer okay
* License: MIT and BSD also okay
Incubating
----------
* Min 2 developers
* Flow of commits or issues addressed -> since mature projects issues addressed could be better indications
Graduated
---------
* Require a stable API -> No major API changes planned in the foreseeable future
* Define how new major API should be introduced, and what support is expected for older major versions (1 back? More?)
* Add link to Swift code style guide
* Encourage the use of formatting tooling + add link to such tools
* Remove Unsafe / make it an example
* CI setup for every platform decanted as supported
* At least one Linux distro
* Remove redundant swift versions support line item
tomerd
requested review from
weissi,
tanner0101,
toddvarland,
loganwright,
kmahar and
tachyonics
|
draft proposal for your review: @weissi @tanner0101 @toddvarland @loganwright @kmahar @tachyonics @PeterAdams-A |
tomerd
changed the title
ktoso
approved these changes
Oct 7, 2020
PeterAdams-A
approved these changes
Oct 7, 2020
| * CI setup for two latest versions of Swift.org recommnded Linux distributions | ||
| * CI setup for two latest Swift.org recommended versions of Swift | ||
| * CI setup for at least one of Swift.org recommended Linux distributions | ||
| * CI setup for each platform supported by the library or tool |
There was a problem hiding this comment.
Swift-NIO runs on anything from Apple Watch up - it doesn't have CI for all the device platforms.
As the swift server working group are we only interested in potential server platforms eg macOS, linux, windows?
| * Packages should be non-blocking (w/ async API) unless not possible (blocking C libs, etc) | ||
| * There should be as little (preferably no) wrapping of NIO as possible. Exposing NIO types directly will go a long way for making packages compatible. | ||
| * Blocking code should be wrapped in NonBlockingIOPool (like Vapor's SQLite package) | ||
| * Uses force unwraps and force tries only as preconditions, ie. conditions that the programmer regards as impossible or programmer error. All force tries/unwraps should come with a comment stating the reasons |
There was a problem hiding this comment.
Use rather than Uses? Similarly Do rather than Does below? Feels like the subject of this section changes as you read through it to me although I wouldn't claim expertise at written text.
tanner0101
approved these changes
Oct 14, 2020
process/incubation.md
Outdated
| * Licensing | ||
| * Apache 2 | ||
| * Apache 2, MIT or BSD (Apache 2 recommended) |
process/incubation.md
Outdated
| * Apache 2, MIT or BSD (Apache 2 recommended) | ||
| * Conventions and Style | ||
| * Adopt [Swift API Design Guidelines](https://swift.org/documentation/api-design-guidelines/) | ||
| * Follow [SSWG Technical Best Practices](#technical-best-practices)) when applicable. |
tachyonics
approved these changes
Oct 14, 2020
weissi
changed the title
kmahar
reviewed
Oct 14, 2020
tomerd
commented
Oct 14, 2020
tomerd
commented
Oct 14, 2020
Co-authored-by: Kaitlin Mahar <kaitlinmahar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: the SSWG reviewed the incubation process on 9/16 and suggested changes
changes:
Sandbox
Incubating
Graduated