diff --git a/lldb/include/lldb/Core/Mangled.h b/lldb/include/lldb/Core/Mangled.h index 5a6e3ac2e4974..246011f18969f 100644 --- a/lldb/include/lldb/Core/Mangled.h +++ b/lldb/include/lldb/Core/Mangled.h @@ -153,13 +153,7 @@ class Mangled { /// Mangled name get accessor. /// /// \return - /// A reference to the mangled name string object. - ConstString &GetMangledName() { return m_mangled; } - - /// Mangled name get accessor. - /// - /// \return - /// A const reference to the mangled name string object. + /// The mangled name string object. ConstString GetMangledName() const { return m_mangled; } /// Best name get accessor. @@ -257,7 +251,7 @@ class Mangled { /// \return /// eManglingSchemeNone if no known mangling scheme could be identified /// for s, otherwise the enumerator for the mangling scheme detected. - static Mangled::ManglingScheme GetManglingScheme(llvm::StringRef const name); + static Mangled::ManglingScheme GetManglingScheme(llvm::StringRef name); static bool IsMangledName(llvm::StringRef name); diff --git a/lldb/source/Core/Mangled.cpp b/lldb/source/Core/Mangled.cpp index d67c5b07e650b..e147cce4842e4 100644 --- a/lldb/source/Core/Mangled.cpp +++ b/lldb/source/Core/Mangled.cpp @@ -49,7 +49,7 @@ bool Mangled::IsMangledName(llvm::StringRef name) { return Mangled::GetManglingScheme(name) != Mangled::eManglingSchemeNone; } -Mangled::ManglingScheme Mangled::GetManglingScheme(llvm::StringRef const name) { +Mangled::ManglingScheme Mangled::GetManglingScheme(llvm::StringRef name) { if (name.empty()) return Mangled::eManglingSchemeNone; diff --git a/lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp b/lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp index 60b50c2e25cab..6e8a2d9379b68 100644 --- a/lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp +++ b/lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp @@ -103,10 +103,10 @@ CPlusPlusLanguage::GetFunctionNameInfo(ConstString name) const { } bool CPlusPlusLanguage::SymbolNameFitsToLanguage(Mangled mangled) const { - const char *mangled_name = mangled.GetMangledName().GetCString(); - auto mangling_scheme = Mangled::GetManglingScheme(mangled_name); - return mangled_name && (mangling_scheme == Mangled::eManglingSchemeItanium || - mangling_scheme == Mangled::eManglingSchemeMSVC); + auto mangling_scheme = + Mangled::GetManglingScheme(mangled.GetMangledName().GetStringRef()); + return mangling_scheme == Mangled::eManglingSchemeItanium || + mangling_scheme == Mangled::eManglingSchemeMSVC; } ConstString CPlusPlusLanguage::GetDemangledFunctionNameWithoutArguments(