From a10fad65cf908cb00f285c9dd3e2812027bc0b1f Mon Sep 17 00:00:00 2001
From: Michael Buch <michaelbuch12@gmail.com>
Date: Mon, 20 Oct 2025 14:47:58 +0100
Subject: [PATCH] [lldb][Swift][NFC] Add m_valid member in URL formatter

We removed the base-class `SyntheticChildrenFrontEnd::m_valid` member in https://github.com/llvm/llvm-project/pull/164249. The URL formatter is the only user of this and should be able to keep track of its own validity without going through the base.
---
 .../Plugins/Language/Swift/FoundationValueTypes.cpp | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/lldb/source/Plugins/Language/Swift/FoundationValueTypes.cpp b/lldb/source/Plugins/Language/Swift/FoundationValueTypes.cpp
index 3643fce29232e..4b1511bf1b87e 100644
--- a/lldb/source/Plugins/Language/Swift/FoundationValueTypes.cpp
+++ b/lldb/source/Plugins/Language/Swift/FoundationValueTypes.cpp
@@ -605,20 +605,18 @@ class URLComponentsSyntheticChildrenFrontEnd
         m_synth_backend_up()
 #define COMPONENT(Name, PrettyName, ID) , m_##Name(nullptr)
 #include "URLComponents.def"
-  {
-    SetValid(false);
-  }
+  {}
 
   ~URLComponentsSyntheticChildrenFrontEnd() override = default;
 
   llvm::Expected<uint32_t> CalculateNumChildren() override {
-    if (IsValid())
+    if (m_valid)
       return 9;
     return 0;
   }
 
   lldb::ValueObjectSP GetChildAtIndex(uint32_t idx) override {
-    if (IsValid()) {
+    if (m_valid) {
       switch (idx) {
 #define COMPONENT(Name, PrettyName, ID)                                        \
   case ID:                                                                     \
@@ -646,7 +644,7 @@ class URLComponentsSyntheticChildrenFrontEnd
 #define COMPONENT(Name, PrettyName, ID) m_##Name = nullptr;
 #include "URLComponents.def"
 
-    SetValid(false);
+    m_valid = false;
 
     ValueObjectSP underlying_sp =
         m_backend.GetChildAtNamePath({g__handle, g__pointer});
@@ -686,7 +684,7 @@ class URLComponentsSyntheticChildrenFrontEnd
     m_##Name->SetName(GetNameFor##Name());
 #include "URLComponents.def"
 
-    SetValid(CheckValid());
+    m_valid = CheckValid();
 
     return ChildCacheState::eRefetch;
   }
@@ -712,6 +710,7 @@ class URLComponentsSyntheticChildrenFrontEnd
 
   SyntheticChildrenFrontEnd::AutoPointer m_synth_frontend_up;
   std::unique_ptr<ObjCRuntimeSyntheticProvider> m_synth_backend_up;
+  bool m_valid = false;
 #define COMPONENT(Name, PrettyName, ID) ValueObject *m_##Name;
 #include "URLComponents.def"