Upstream ns_error_domain attribute #1565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gribozavr, @DougGregor, I would appreciate your review on this change. |
|
LGTM! @DougGregor could you review & merge? |
|
Thanks for the review. Please don't merge, yet. I think I may have found an issue. I'll mark this as draft while I investigate (tomorrow). |
|
This is ready for review (and merging) now. |
|
I've added an additional test from the upstream code review and rebased against @DougGregor, can you review and merge this? |
|
Hi @DougGregor, we do have commit rights for this branch now, so we can also move ahead on our own. We are still interested in your feedback, though, if you have time. |
DougGregor
approved these changes
Aug 12, 2020
This change proactively applies the changes that have been made to ns_error_domain during upstreaming to avoid merge conflicts when the change trickles down. Original changelist description: ns_error_domain can be used by, e.g. NS_ERROR_ENUM, in order to identify a global declaration representing the domain constant. Introduces the attribute, Sema handling, diagnostics, and test case. This is cherry-picked from llvm/llvm-project-staging@a14779f and adapted to updated Clang APIs.
This had been changed during upstreaming of the attribute and needs some updates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two commits in this pull request:
The first commit proactively applies the changes that have been made to
ns_error_domainduring upstreaming to avoid merge conflicts when the change trickles down. This has been reviewed upstream at D84005, but not submitted, yet. If more comments come up for this part, I would apply them to the upstream code review.The second commit adds additional changes for APInotes that have not been reviewed, yet.