[5.5][llvm-cov] Check path emptyness in path-equivalence after removing dots. #3205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit dd388ba)
|
@fredriss since you're mentioned as the release manager |
|
@fredriss can you check out this one too? |
|
This definitely missed the train, this fix is included in 5.6 which shipped with Xcode 13.3 |
keith
deleted the
ks/llvm-cov-check-path-emptyness-in-path-equivalence-after-removing-dots
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit dd388ba)
Without this when using
-coverage-prefix-mapto remove absolute paths from your binaries, you can get a crash remapping those to the true paths with llvm-cov.