[5.5] Revert "[llvm-cov] reset executation count to 0 after wrapped segment" #3244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…egment" This was discovered to break Swift's code coverage analysis, but wasn't picked after being reverted upstream. More info: https://reviews.llvm.org/D85036 https://bugs.llvm.org/show_bug.cgi?id=49297 Differential Revision: https://reviews.llvm.org/D98084 (cherry picked from commit 8d5c3ae)
|
@fredriss since you're mentioned as the release manager |
|
@vedantk since it appears you discovered this issue a while back |
|
Paging @airspeedswift as this eventually changes the Swift compiler |
|
This definitely missed the train, this fix is included in 5.6 which shipped with Xcode 13.3 |
keith
deleted the
ks/5.5-revert-llvm-cov-reset-executation-count-to-0-after-wrapped-segment
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was discovered to break Swift's code coverage analysis, but wasn't
picked after being reverted upstream.
More info: https://reviews.llvm.org/D85036 https://bugs.llvm.org/show_bug.cgi?id=49297
Differential Revision: https://reviews.llvm.org/D98084
(cherry picked from commit 8d5c3ae)