Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for JSON-XPC transport for the ClangdXPC.framework #112

Closed
wants to merge 2 commits into from

Conversation

hyp
Copy link
Contributor

@hyp hyp commented Jun 25, 2019

This patch adds support for the XPC transport layer that is used by ClangdXPC.framework.

A couple of notes:

  • A lot of code between the JSON and XPC connection is the same. I think it might be possible to share it by using a common base class / protocol. @benlangmuir, WDYT?
  • Tested locally, but swift-ci doesn't build the XPC framework yet, so it won't be tested in CI. I'll have to fix that too.

@hyp hyp requested review from benlangmuir and jkorous-apple June 25, 2019 21:40
@benlangmuir
Copy link
Contributor

Could you say a bit about the choice not to use XPC's own API for sending a message with a reply?

@hyp
Copy link
Contributor Author

hyp commented Jun 26, 2019

Could you say a bit about the choice not to use XPC's own API for sending a message with a reply?

It looks like send_with_reply only catches the reply if the server sends the response using the xpc_dictionary_create_reply function. Unfortunately we currently don't support that in Clangd, and we send responses back without preserving the XPC reply link. Do you think that should be fixed first?

@hyp
Copy link
Contributor Author

hyp commented Jun 29, 2019

Updated to use XPC data instead of string to match : https://reviews.llvm.org/D63961

@shahmishal shahmishal closed this Oct 6, 2020
@shahmishal
Copy link
Member

The Swift project moved the default branch to main and deleted master branch, so GitHub automatically closed the PR. Please re-create the pull request with main branch.

More detail about the branch update - https://forums.swift.org/t/updating-branch-names/40412

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants