Explicitly implement syntacticTestItems in DocumentationLanguageService
#2278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rvice` `SyntacticTestIndex` queries all language services for a document for its syntactic test items. This caused `syntacticDocumentTests not implemented in DocumentationLanguageService` to be logged for every Swift file in the project. Remove the default implementation of `syntacticDocumentTests` in `LanguageService` and instead provide an implementation that returns an empty array in `DocumentationLanguageService`. While at it, also log the files for which unimplemented methods are called on `LanguageService`. This makes it easier to dermine why they are called.
ahoppen
requested review from
bnbarham,
hamishknight and
rintaro
as code owners
Member
Author
|
@swift-ci Please test |
bnbarham
approved these changes
Sep 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SyntacticTestIndexqueries all language services for a document for its syntactic test items. This causedsyntacticDocumentTests not implemented in DocumentationLanguageServiceto be logged for every Swift file in the project. Remove the default implementation ofsyntacticDocumentTestsinLanguageServiceand instead provide an implementation that returns an empty array inDocumentationLanguageService.While at it, also log the files for which unimplemented methods are called on
LanguageService. This makes it easier to dermine why they are called.