Add support for fixed compilation database (compile_flags.txt) #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benlangmuir
suggested changes
Mar 13, 2021
|
This looks great, just a couple of minor comments. Thanks! |
|
Thanks for the review Ben! Made the changes. |
|
@swift-ci please test |
benlangmuir
approved these changes
Mar 15, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small change adds support for fixed compilation database (compile_flags.txt), ideal for simple codebases that do not use CMake with an auto-generated compile_commands.json file.
See clangd's compilation database documentation under Alternatives.
@benlangmuir