Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flag warnings introduced by a PR by running a CI check #58

Open
Kyle-Ye opened this issue Nov 3, 2022 · 0 comments
Open

Flag warnings introduced by a PR by running a CI check #58

Kyle-Ye opened this issue Nov 3, 2022 · 0 comments
Labels
Build issue A problem or enhancement in the tools that build and publish this book Enhancement New feature or request

Comments

@Kyle-Ye
Copy link
Contributor

Kyle-Ye commented Nov 3, 2022 •
edited by amartini51
Loading

After #1, #36 and swiftlang/swift-docc#377 were resolved, currently there should be no warnings when building the newest swift-book using the newest swift-docc.

Input:
    /Users/kyle/Workspace/Github/swift-docc-project/swift-book/Sources/TSPL/TSPL.docc
Template:
    /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault
    .xctoolchain/usr/bin/../share/docc/render
==============================
Starting Local Preview Server
    Address: http://localhost:8080/
==============================
Monitoring
    /Users/kyle/Workspace/Github/swift-docc-project/swift-book/Sources/TSPL/TSPL.docc

Maybe we should consider to config a CI check to make sure a future PR will not produce any new warning or error(with --warnings-as-errors enabled on swift-docc side).

https://forums.swift.org/t/add-support-for-warnings-as-errors/59832/5
@Kyle-Ye Kyle-Ye added the Enhancement New feature or request label Nov 3, 2022
@amartini51 amartini51 changed the title Add CI check for swift-book's PR Flag warnings or errors introduced by a PR by running a CI check Nov 3, 2022
@amartini51 amartini51 added the Build issue A problem or enhancement in the tools that build and publish this book label Nov 3, 2022
@amartini51 amartini51 changed the title Flag warnings or errors introduced by a PR by running a CI check Flag warnings introduced by a PR by running a CI check Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Build issue A problem or enhancement in the tools that build and publish this book Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amartini51 @Kyle-Ye