-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README for guiding docc location #164
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a good addition to the instructions in general, since most people won't have docc in their path by default. It might be worth telling people about the xcrun approach first.
Co-authored-by: Kyle Murray <krilnon@users.noreply.github.com>
Co-authored-by: Kyle Murray <krilnon@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Seems comprehensive enough that most people should be able to get up-and-running with these additions.
Frame these more as steps in the process and less as troubleshooting. Include the "Note" text at the start of the note box, as called for by editorial guidelines. Make the wording for the Swift toolchain and Xcode parallel. Match standard styling of Swift.org (upper case S).
|
I pushed a bit of a rewrite in a83f76e with some more detailed notes about the changes in that commit. Overall, I'm not entirely sure that it's the README's job to explain how to install DocC. It might be better if we can find (or write) some documentation in the DocC project about how to install and use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the rewrite.
Any wording review comments are welcomed.
https://forums.swift.org/t/unable-to-build-swift-book-via-docc/66342
Fixes: #163