Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README for guiding docc location #164

Merged
merged 5 commits into from
Aug 2, 2023

Conversation

Kyle-Ye
Copy link
Contributor

@Kyle-Ye Kyle-Ye commented Jul 25, 2023

Any wording review comments are welcomed.

https://forums.swift.org/t/unable-to-build-swift-book-via-docc/66342

Fixes: #163

Copy link
Contributor

@krilnon krilnon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good addition to the instructions in general, since most people won't have docc in their path by default. It might be worth telling people about the xcrun approach first.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Kyle-Ye and others added 3 commits July 27, 2023 03:10
Co-authored-by: Kyle Murray <krilnon@users.noreply.github.com>
Co-authored-by: Kyle Murray <krilnon@users.noreply.github.com>
@Kyle-Ye Kyle-Ye requested a review from krilnon July 26, 2023 19:11
Copy link
Contributor

@krilnon krilnon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Seems comprehensive enough that most people should be able to get up-and-running with these additions.

Frame these more as steps in the process and less as troubleshooting.

Include the "Note" text at the start of the note box, as called for by
editorial guidelines.

Make the wording for the Swift toolchain and Xcode parallel.

Match standard styling of Swift.org (upper case S).
@amartini51
Copy link
Member

I pushed a bit of a rewrite in a83f76e with some more detailed notes about the changes in that commit.

Overall, I'm not entirely sure that it's the README's job to explain how to install DocC. It might be better if we can find (or write) some documentation in the DocC project about how to install and use docc that this README can link to.

README.md Show resolved Hide resolved
Copy link
Contributor Author

@Kyle-Ye Kyle-Ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the rewrite.

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@Kyle-Ye Kyle-Ye requested a review from amartini51 July 27, 2023 03:36
@amartini51 amartini51 requested a review from krilnon July 27, 2023 05:07
@amartini51 amartini51 merged commit f74aa1f into swiftlang:main Aug 2, 2023
@amartini51 amartini51 deleted the optimize/docc branch August 2, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to preview site via docc preview TSPL.docc
3 participants