Show example of nested protocols [SE-0404] #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pulling this back to draft because |
This approach doesn't rely (directly or indirectly) on existential types. The old example used two protocols at the same scope, in part because protocol nesting wasn't supported when this was first written. That's no longer needed -- we can now show a delegate protocol nested inside the type it supports.
The discussion of how the delegate can access the type that's doing the delegation is no longer relevant -- DiceGameTracker doesn't access any game state, and there's no longer a need to define a protocol for the delegating type to conform to. So that explanation was removed without replacement.
Co-authored-by: Karl <5254025+karwa@users.noreply.github.com>
chuckdude
approved these changes
Feb 5, 2024
There was a problem hiding this comment.
Approved with suggested edits. There are a couple suggested wording changes in here, but prefer defaulting to overall style of the Guide if there's a conflict.
Please let me know if you'd like to discuss or feel free to incorporate the revisions and merge.
Thank you.
Co-authored-by: Chuck Toporek <chuck_toporek@apple.com>
bjlanier
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Didn't add an example to the tour, because it doesn't show nested types — we can revise that separately.
Fixes: rdar://117101695