code review: prefer if let to catch null case

Coeur · Coeur · commit b24b0f235fc6 · 2024-09-05T02:13:15.000+02:00
diff --git a/Sources/FoundationNetworking/URLResponse.swift b/Sources/FoundationNetworking/URLResponse.swift
@@ -46,8 +46,11 @@ open class URLResponse : NSObject, NSSecureCoding, NSCopying, @unchecked Sendabl
         }
         
         // re-sanitizing with lastPathComponent because of supportsSecureCoding
-        let encodedFilename = aDecoder.decodeObject(of: NSString.self, forKey: "NS.suggestedFilename")?.lastPathComponent
-        self.suggestedFilename = encodedFilename?.isEmpty != false ? "Unknown" : encodedFilename
+        if let encodedFilename = aDecoder.decodeObject(of: NSString.self, forKey: "NS.suggestedFilename")?.lastPathComponent, !encodedFilename.isEmpty {
+            self.suggestedFilename = encodedFilename
+        } else {
+            self.suggestedFilename = "Unknown"
+        }
     }
     
     open func encode(with aCoder: NSCoder) {

Original file line number	Diff line number	Diff line change
`@@ -46,8 +46,11 @@ open class URLResponse : NSObject, NSSecureCoding, NSCopying, @unchecked Sendabl`
`46`	`46`	`}`
`47`	`47`
`48`	`48`	`// re-sanitizing with lastPathComponent because of supportsSecureCoding`
`49`		`- let encodedFilename = aDecoder.decodeObject(of: NSString.self, forKey: "NS.suggestedFilename")?.lastPathComponent`
`50`		`- self.suggestedFilename = encodedFilename?.isEmpty != false ? "Unknown" : encodedFilename`
	`49`	`+ if let encodedFilename = aDecoder.decodeObject(of: NSString.self, forKey: "NS.suggestedFilename")?.lastPathComponent, !encodedFilename.isEmpty {`
	`50`	`+ self.suggestedFilename = encodedFilename`
	`51`	`+ } else {`
	`52`	`+ self.suggestedFilename = "Unknown"`
	`53`	`+ }`
`51`	`54`	`}`
`52`	`55`
`53`	`56`	`open func encode(with aCoder: NSCoder) {`