[SR-438] 'make distcheck' fails due to `fatal error: 'linux_port.h' file not found`

[drewcrawford]

Previous ID	SR-438
Radar	None
Original Reporter	@drewcrawford
Type	Bug
Status	Closed
Resolution	Done

Environment

Linux x64

Additional Detail from JIRA

Votes	0
Component/s	libdispatch
Labels	Bug
Assignee	dgrove-oss (JIRA)
Priority	Medium

md5: f73b104e22817c248c75626a4c20c6ba

Issue Description:

Running 'make distcheck' produces an error due to a missing linux_port.h.

I cannot find this file in the repository, so I'm not really sure what is intended to happen here.

/bin/bash ../libtool  --tag=CC   --mode=compile clang -DHAVE_CONFIG_H -I. -I../../tests -I../config  -I.. -I../..  -Wall -Wno-deprecated-declarations  -fblocks -I/usr/include/kqueue  -isystem /usr/include/bsd -DLIBBSD_OVERLAY    -g -O2 -c -o dispatch_test.lo ../../tests/dispatch_test.c
libtool: compile:  clang -DHAVE_CONFIG_H -I. -I../../tests -I../config -I.. -I../.. -Wall -Wno-deprecated-declarations -fblocks -I/usr/include/kqueue -isystem /usr/include/bsd -DLIBBSD_OVERLAY -g -O2 -c ../../tests/dispatch_test.c  -fPIC -DPIC -o .libs/dispatch_test.o
In file included from ../../tests/dispatch_test.c:21:
../../tests/dispatch_test.h:26:10: fatal error: 'linux_port.h' file not found
#include <linux_port.h>
         ^
1 error generated.

[drewcrawford]

cc @parkera

[parkera]

Hm, the file is there in my repository (Tests directory). Maybe you need to re-execute all of the autoconf stuff?

[drewcrawford]

No, unfortunately my autoconf stuff is fresh. Here's reproduction steps that are based on Docker and therefore portable.

1. Clone repo
2. Create this Dockerfile in the working directory:

FROM debian:latest
RUN apt-get update && apt-get install clang autoconf libtool pkg-config systemtap-sdt-dev libblocksruntime-dev libkqueue-dev libpthread-workqueue-dev libbsd-dev automake build-essential -y --no-install-recommends
ADD . /libdispatch
WORKDIR libdispatch
RUN ./autogen.sh
RUN ./configure --prefix=/tmp/libdispatch
RUN make distcheck

3. Run "docker build ."

This produces the error

In file included from ../../tests/dispatch_test.c:21:
../../tests/dispatch_test.h:26:10: fatal error: 'linux_port.h' file not found
#include <linux_port.h>
         ^
1 error generated.

It does look like tests/linux_port.h exists, but for some reason it's not in the include path for this target? Is "distcheck" a supported argument to even pass to make?

[swift-ci]

Comment by David Grove (JIRA)

Hi.

I think the reason distcheck is failing is that we didn't include linux_port.h in libbsdtests_la_SOURCES in tests/Makefile.am. We're still working on getting the last couple of test cases passing on Linux; then we should clean this up (either by getting distcheck to work or by eliminating linux_port.h entirely by moving its contents into dispatch_tests.h to avoid needing a separate header for a handful of additional definitions).

[swift-ci]

Comment by David Grove (JIRA)

Resolved by:
commit 1a9c57f
Merge: 8beb877 91268ec
Author: Pierre Habouzit <phabouzit@apple.com>
Date: Tue Feb 9 08:47:25 2016 -0800

Merge pull request #48 from dgrove-oss/fix-distcheck

SR-438: 'make distcheck' fails for libdispatch on Linux