Fixes overflow trap when creating DispatchTime objects with large upt… #311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please test |
ktopley-apple
force-pushed
the
dispatch-timebase-overflow
branch
from
abbe7d2 to
6aedc05
Compare
Contributor
Author
|
@swift-ci please test |
mwwa
approved these changes
Oct 12, 2017
…imeNanoseconds values.
ktopley-apple
force-pushed
the
dispatch-timebase-overflow
branch
from
6aedc05 to
4195ac6
Compare
Contributor
Author
|
Squashed commits |
ktopley-apple
added a commit
that referenced
this pull request
Dec 6, 2018
Fixes overflow trap when creating DispatchTime objects with large upt… Signed-off-by: Daniel A. Steffen <dsteffen@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…imeNanoseconds values.
(rdar://problem/34922683)
[related to change https://github.com/swiftlang/swift/pull/12387]
The change is in three parts:
The value UInt64.max passed to the DispatchTime initializer means DISPATCH_TIME_FOREVER and should not be scaled using the Mach timebase.
The scaling calculations need to detect overflow and clamp to UInt64.max if this occurs, making the value equal to DISPATCH_TIME_FOREVER
The getter for the uptimeNanoseconds also needs to be protected against overflow and return UInt64.max if it occurs.