build: ensure that dependencies are tracked properly #324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
Member
Author
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
Use `add_custom_command` and `add_custom_target`. This ensures that the ordering dependencies are properly honoured by ninja. This fixes an issue where sometimes I would see `swiftDispatch` being built prior to the module map symlinks being established.
compnerd
force-pushed
the
command-target
branch
from
eb9667e to
1db5a9a
Compare
Member
Author
|
@swift-ci please test |
Member
Author
|
@Rostepher want to merge this? |
Member
Author
|
@MadCoder ping? |
Member
Author
|
CC: @aschwaighofer |
ktopley-apple
pushed a commit
that referenced
this pull request
Dec 6, 2018
build: ensure that dependencies are tracked properly Signed-off-by: Daniel A. Steffen <dsteffen@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
add_custom_commandandadd_custom_target. This ensures that theordering dependencies are properly honoured by ninja. This fixes an
issue where sometimes I would see
swiftDispatchbeing built prior tothe module map symlinks being established.