dispatch: adjust for LLP64 environments #341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LLP64 environments use a 32-bit long value. This would result in truncation as the `long` is used to transfer a pointer value here. Adjust the types accordingly. Since the width on LP64 environments is equivalent in this change, this should only impact LLP64 environments and be ABI stable otherwise.
Member
Author
Member
Author
|
@swift-ci please test |
MadCoder
suggested changes
Feb 22, 2018
| */ | ||
| DISPATCH_SWIFT3_UNAVAILABLE("Use lazily initialized globals instead") | ||
| typedef long dispatch_once_t; | ||
| typedef intptr_t dispatch_once_t; |
Contributor
There was a problem hiding this comment.
should really be uintptr_t I don't like signed integers for these.
Member
Author
There was a problem hiding this comment.
Sure, I only used intptr_t since it was long which is a signed value.
Contributor
There was a problem hiding this comment.
oh right and since it's API it may cause build fallouts... ok convinced let's keep intptr_t ugh
MadCoder
approved these changes
Feb 22, 2018
ktopley-apple
pushed a commit
that referenced
this pull request
Dec 6, 2018
dispatch: adjust for LLP64 environments Signed-off-by: Daniel A. Steffen <dsteffen@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLP64 environments use a 32-bit long value. This would result in
truncation as the
longis used to transfer a pointer value here.Adjust the types accordingly. Since the width on LP64 environments is
equivalent in this change, this should only impact LLP64 environments
and be ABI stable otherwise.