event: implement source muxing on Windows #512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement the cases in `_dispatch_unote_register_muxed()` and `_dispatch_unote_unregister_muxed()` for when multiple event sources are open on a handle and we need to combine them. The test suite doesn't hit these codepaths anywhere and we haven't run into issues with Foundation yet, so I added a dispatch_io_muxed test which opens multiple sources on a file/pipe/socket and checks that events fire correctly.
Contributor
Author
Contributor
|
@swift-ci please test |
rokhinip
pushed a commit
that referenced
this pull request
Nov 5, 2021
event: implement source muxing on Windows Signed-off-by: Rokhini Prabhu <rokhinip@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the cases in
_dispatch_unote_register_muxed()and_dispatch_unote_unregister_muxed()for when multiple event sources areopen on a handle and we need to combine them.
The test suite doesn't hit these codepaths anywhere and we haven't run
into issues with Foundation yet, so I added a dispatch_io_muxed test
which opens multiple sources on a file/pipe/socket and checks that
events fire correctly.