build: remove unnecessary flag to control the linker #513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@swift-ci please test |
Contributor
|
@compnerd looks like you forgot to remove the dispatch_set_linker(dispatch) call in src/CMakeLists.txt. |
The `SWIFT_LINKER_FLAGS` allows the user to specify the linker that they want for Swift and C/C++ have their own flags which let you control flags which should permit control of the C/C+ linker. This removes the unnecessary logic for controlling the linker. This simplification always paves the way for migrating further to CMake 3.15+.
compnerd
force-pushed
the
linker-be-gone
branch
from
3ba8cb5 to
1aa51bf
Compare
Contributor
|
@swift-ci please test |
ktopley-apple
approved these changes
Aug 26, 2019
rokhinip
pushed a commit
that referenced
this pull request
Nov 5, 2021
build: remove unnecessary flag to control the linker Signed-off-by: Rokhini Prabhu <rokhinip@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
SWIFT_LINKER_FLAGSallows the user to specify the linker that theywant for Swift and C/C++ have their own flags which let you control
flags which should permit control of the C/C+ linker. This removes the
unnecessary logic for controlling the linker. This simplification
always paves the way for migrating further to CMake 3.15+.