Skip to content

build: port to new Swift support #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 26, 2019
Merged

build: port to new Swift support #519

merged 1 commit into from
Sep 26, 2019

Conversation

@compnerd
Copy link
Member

@compnerd compnerd commented Sep 17, 2019

This ports the libdispatch build to use the new builtin Swift support in
CMake. It allows for a significant clean up of the build rules.

@compnerd
Copy link
Member Author

compnerd commented Sep 17, 2019

@swift-ci please test

1 similar comment
@compnerd
Copy link
Member Author

compnerd commented Sep 18, 2019

@swift-ci please test

@compnerd
Copy link
Member Author

compnerd commented Sep 19, 2019

Please test with the following PRs:
swiftlang/swift#27245

@swift-ci please test

@compnerd
Copy link
Member Author

compnerd commented Sep 20, 2019

@swift-ci please test

@compnerd
Copy link
Member Author

compnerd commented Sep 20, 2019

Please test with following PR:
swiftlang/swift#27271

@swift-ci please test

@compnerd
Copy link
Member Author

compnerd commented Sep 20, 2019

Please test with following PR:
swiftlang/swift#27271

@swift-ci please test

@compnerd
Copy link
Member Author

compnerd commented Sep 20, 2019

Please test with following PR:
swiftlang/swift#27271

@swift-ci please test

@compnerd
Copy link
Member Author

compnerd commented Sep 23, 2019

@swift-ci please test

@compnerd
Copy link
Member Author

compnerd commented Sep 23, 2019

Please test with following PRs:
swiftlang/swift-corelibs-foundation#2519

@swift-ci please test

1 similar comment
@compnerd
Copy link
Member Author

compnerd commented Sep 25, 2019

Please test with following PRs:
swiftlang/swift-corelibs-foundation#2519

@swift-ci please test

@compnerd
Copy link
Member Author

compnerd commented Sep 25, 2019

Please test with following PRs:
swiftlang/swift-corelibs-foundation#2519
swiftlang/swift-corelibs-xctest#285

@swift-ci please test

@compnerd
Copy link
Member Author

compnerd commented Sep 25, 2019

Please test with following PRs:
swiftlang/swift-corelibs-foundation#2519
swiftlang/swift-corelibs-xctest#285
swiftlang/swift-package-manager#2352

@swift-ci please test

1 similar comment
@compnerd
Copy link
Member Author

compnerd commented Sep 25, 2019

Please test with following PRs:
swiftlang/swift-corelibs-foundation#2519
swiftlang/swift-corelibs-xctest#285
swiftlang/swift-package-manager#2352

@swift-ci please test

@compnerd
build: port to new Swift support
37ec01e 
This ports the libdispatch build to use the new builtin Swift support in
CMake. It allows for a significant clean up of the build rules.
@compnerd
Copy link
Member Author

compnerd commented Sep 25, 2019

Please test with following PRs:
swiftlang/swift-corelibs-foundation#2519
swiftlang/swift-corelibs-xctest#285
swiftlang/swift-package-manager#2352

@swift-ci please test

@compnerd compnerd mentioned this pull request Sep 25, 2019
Closed
@compnerd
Copy link
Member Author

compnerd commented Sep 25, 2019

@ktopley-apple - okay to merge? (I'm going to wait until swiftlang/swift#27372 is green though)

@compnerd compnerd merged commit ec3fd9b into swiftlang:master Sep 26, 2019
@compnerd compnerd deleted the swift-support branch September 26, 2019 15:21
@shahmishal
Copy link
Member

shahmishal commented Sep 26, 2019

Swift CI is checking out tag v3.15.0, is it possible to change the min requirement to 3.15.0 compare to 3.15.1?

https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-14_04-long-test/7178/console

10:16:05 CMake Error at CMakeLists.txt:2 (cmake_minimum_required):
10:16:05   CMake 3.15.1 or higher is required.  You are running version 3.15.0
10:16:05 
10:16:05 
10:16:05 -- Configuring incomplete, errors occurred!

@shahmishal shahmishal mentioned this pull request Sep 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ktopley-apple ktopley-apple ktopley-apple approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@compnerd @shahmishal @triplef @ktopley-apple @das