Update RenderIndex.Node's initializer to accept an optional type #1360
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since RenderIndex.Node’s type property is optional, the public initializer should accept an optional.
patshaughnessy
approved these changes
Nov 19, 2025
Contributor
|
@swift-ci please test |
d-ronnqvist
approved these changes
Nov 19, 2025
mayaepps
added a commit
to mayaepps/swift-docc
that referenced
this pull request
Dec 4, 2025
Since RenderIndex.Node’s type property is optional, the public initializer should accept an optional. Co-authored-by: Pat Shaughnessy <pat_shaughnessy@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable:
Summary
If a caller needs to initialize a
RenderIndex.Nodeobject with an optionaltypevalue, they cannot do so. SinceRenderIndex.Node’stypeproperty is optional, the public initializer should accept an optional.Dependencies
N/A
Testing
Create a
RenderIndex.Nodeobject, and confirm that you can provide anilvalue to the initializer without compilation errors.Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
./bin/testscript and it succeeded