Always diagnose failures in job execution #1978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Execution of the `MultiJobExecutor` throws a `Driver.ErrorDiagnostics.emitted` if the job was not successful, ie. it assume any errors were already emitted. Make sure to emit an error in all paths of `ExecuteJobRule.executeJob` so that failures aren't hidden.
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
Interested in opinions for what this message should be - right now this becomes an (This came up in investigating the fatalError we were seeing sometimes on Windows: swiftlang/swift#83606 (comment)) |
owenv
approved these changes
Sep 2, 2025
artemcm
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Execution of the
MultiJobExecutorthrows aDriver.ErrorDiagnostics.emittedif the job was not successful, ie. it assume any errors were already emitted. Make sure to emit an error in all paths ofExecuteJobRule.executeJobso that failures aren't hidden.