Skip to content

Conversation

@cachemeifyoucan
Copy link
Contributor

@cachemeifyoucan cachemeifyoucan commented Nov 24, 2025

Fix some tests that fails on older swift compiler versions and windows platform

@cachemeifyoucan cachemeifyoucan marked this pull request as draft November 24, 2025 07:38
@cachemeifyoucan cachemeifyoucan force-pushed the eng/fix-all-gh-actions branch 4 times, most recently from 699a9cf to 924acc3 Compare November 24, 2025 12:58
@cachemeifyoucan cachemeifyoucan force-pushed the eng/fix-all-gh-actions branch 2 times, most recently from f3b0845 to 347668b Compare November 27, 2025 00:48
withTemporaryFile leads to permission errors when creating a temporary
file directly in the system temp directory. Using temporary directories
for testing instead.
@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please test

@cachemeifyoucan cachemeifyoucan marked this pull request as ready for review November 27, 2025 05:38
@cachemeifyoucan cachemeifyoucan requested review from artemcm, compnerd and sepy97 and removed request for artemcm and sepy97 November 27, 2025 05:38
@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please test windows platform

@cachemeifyoucan cachemeifyoucan changed the title Fix all GitHub action tests [TEST-ONLY] Fix more GitHub action tests Dec 1, 2025
@cachemeifyoucan
Copy link
Contributor Author

@swift-ci please test windows platform

Copy link
Contributor

@artemcm artemcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@cachemeifyoucan cachemeifyoucan merged commit 0764248 into swiftlang:main Dec 2, 2025
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants