Proposal for @noImplicitCopy attribute for local variable and parameter bindings
#1846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atrick
reviewed
Nov 21, 2022
| // We can still use x because we only borrowed its payload | ||
|
|
||
| switch x { | ||
| case .some(borrow y): |
There was a problem hiding this comment.
Was shadowing 'y' intentional here?
There was a problem hiding this comment.
There isn't any shadowing, really, since if borrow y would be out of scope by the time we reach the switch. But I can still change the name to be clear.
Also: - handle editing feedback from @atrick and @benrimmington - rename `take` to `consume` in alignment with SE-0366/SE-0377
jckarter
changed the title
@noImplicitCopy attribute for immutable bindings@noImplicitCopy attribute for local variable and parameter bindings
|
We're going a different direction with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.