Add proposal for @OptionSet macro #1968
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DougGregor
reviewed
Mar 6, 2023
| This will require the addition of the `@OptionSet` macro declaration to the standard library: | ||
|
|
||
| ```swift | ||
| @attached(member) |
There was a problem hiding this comment.
Suggested change
| @attached(member) | |
| @attached(member, names: arbitrary) |
DougGregor
reviewed
Mar 6, 2023
| ```swift | ||
| @attached(member) | ||
| @attached(conformance) | ||
| public macro OptionSet<RawType>() = #externalMacro(module: "MacroExamplesPlugin", type: "OptionSetMacro") |
There was a problem hiding this comment.
This will be used as @OptionSet<UInt8> or similar. If we want to infer the raw value type, we'll need to do something differently. And I think we'll want a defaulted parameter that provides the name of the Options enum?
There was a problem hiding this comment.
The proposal and implementation(s) use RawType, but the (non-primary) associated type is RawValue.
amartini51
added a commit
to swiftlang/swift-book
that referenced
this pull request
Jul 14, 2023
OptionSet was included in the version of the Swift standard
library that shipped with beta 1:
https://github.com/apple/swift/blob/release/5.9-20230510/stdlib/public/core/Macros.swift#L93
However, it has since been reverted:
swiftlang/swift#66403 (merged into 'main')
swiftlang/swift#66404 (cherry pick to 5.9 release branch)
We should watch for it to be approved in the Swift Evolution process,
and then re-add the link (assuming it gets approved):
https://forums.swift.org/t/63547
swiftlang/swift-evolution#1968
Fixes: rdar://111109664
rjmccall
added
the
LSG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relies on SE-0389