Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SE-0364 to new @retroactive syntax #1969

Merged
merged 2 commits into from
Apr 25, 2023

Conversation

harlanhaskins
Copy link
Contributor

This updates the proposal to the new @retroactive Protocol syntax and expands on the attribute's semantics.

@benrimmington
Copy link
Contributor

In the "proposed solution" section, please could you:

  • split the warning across several lines (to avoid scrolling);
  • enable syntax highlighting for the second example.

Should the imported type and protocol be fully-qualified in the warning message?

// warning: extension declares a conformance of imported type 'Foundation.Date'
// to imported protocol 'Swift.Identifiable'; this will not behave correctly if
// the owners of 'Foundation' introduce this conformance in the future
extension Date: Identifiable {
^

@stephentyrone stephentyrone merged commit b3ffb0b into swiftlang:main Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants