Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the chronological order of proposal review discussions #2402

Merged

Conversation

dempseyatgithub
Copy link
Contributor

@dempseyatgithub dempseyatgithub commented Apr 15, 2024

The forum discussions listed in the "Review" heading field should be in chronological order.

This PR corrects the chronological order of proposals and, in those proposals, also normalizes naming, order, formatting to match the format and directions in the profile template:

Review is a history of all discussion threads about this proposal, in chronological order. Use these standardized link names: pitch review revision acceptance rejection. If there are multiple such threads, spell the ordinal out: first pitch second review etc.

This is in preparation for changes to the SE Dashboard metadata extractor where review discussions will be included.

Note to keep the size of this PR manageable, it only focuses on proposals with discussions in incorrect chronological order.

For these proposals, also:
- Normalize discussion naming according to template instructions
  (e.g. 'first pitch', 'acceptance', 'returned'
- Normalize use of 'Review' heading label
Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@DougGregor DougGregor merged commit 27c506c into swiftlang:main Apr 16, 2024
@dempseyatgithub dempseyatgithub deleted the review-chonological-order branch April 17, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants